这个程序运行为什么崩溃

进无止进

1. #include <stdio.h>
   
2. #include <stdlib.h>
   
3. #include <string.h>
   
4. 
   
5. #define MAX_NAME_LENGTH 20
   
6. #define MAX_STUDENT_NUMBER 10
   
7. #define MAX_CLASS_NUMBER 10
   
8. 
   
9. typedef struct student
   
10. {
    
11.         char name[MAX_NAME_LENGTH];
    
12.         unsigned short int age;
    
13.         unsigned short int class_number;
    
14.         unsigned short int chinese_scores;
    
15.         unsigned short int math_scores;
    
16.         unsigned short int english_scores;
    
17.        
    
18. }Student;
    
19. 
    
20. typedef struct stu_class
    
21. {
    
22.         Student students[MAX_STUDENT_NUMBER];
    
23.         unsigned short int class_number;
    
24.        
    
25. }Stu_Class;
    
26. 
    
27. typedef struct class_system
    
28. {
    
29.         Stu_Class stu_class[MAX_CLASS_NUMBER];
    
30.         //unsigned short int class_sum;
    
31. }Class_System;
    
32. 
    
33. Class_System class_system;
    
34. 
    
35. void Init_Class_System()
    
36. {
    
37.         memset(&class_system,0,sizeof(Class_System));
    
38.         printf("class_system initialization success\n");
    
39. }
    
40. 
    
41. void Add_A_Student_To_Class_System()
    
42. {
    
43.         char name[MAX_NAME_LENGTH] ={'\0'};
    
44.         unsigned short int age;
    
45.         unsigned short int class_number;
    
46.         unsigned short int chinese_scores;
    
47.         unsigned short int math_scores;
    
48.         unsigned short int english_scores;
    
49.         unsigned short int number;
    
50.         printf("please input name,age,class_number(1-9),chinese score,math score, english score and the number(1-9)\n");
    
51. 
    
52.         scanf("%s,%d,%d,%d,%d,%d,%d\n",name,&age,&class_number,
    
53.                 &chinese_scores,&math_scores,&english_scores,&number);
    
54. 
    
55.         strcpy(class_system.stu_class[class_number].students[number].name,name);
    
56.         class_system.stu_class[class_number].students[number].age = age;
    
57.         class_system.stu_class[class_number].students[number].class_number = class_number;
    
58.         class_system.stu_class[class_number].students[number].chinese_scores = chinese_scores;
    
59.         class_system.stu_class[class_number].students[number].math_scores = math_scores;
    
60.         class_system.stu_class[class_number].students[number].english_scores = english_scores;
    
61. 
    
62.         printf("Add student info success!\n");
    
63. }
    
64. 
    
65. int main()
    
66. {
    
67.         int i;
    
68.         Init_Class_System();
    
69.         for(i = 0; i<10;i++)
    
70.         {
    
71.                 Add_A_Student_To_Class_System();
    
72.         }
    
73. 
    
74.         return 0;
    
75. }

复制代码

451006071

因为scanf函数输入错误，导致其他值没有被赋值。然后访问数组成员时越界导致的segment fault。
修改一下scanf就好了。scanf输入%s时需要额外注意，他只能放在所有数字输入之后，或者单独输入一行用于保存文本(name)。%s在最开头表示整行输入数据都给了name，导致其余变量没有正确的值。
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#define MAX_NAME_LENGTH 20
#define MAX_STUDENT_NUMBER 10
#define MAX_CLASS_NUMBER 10

typedef struct student
{
        char name[MAX_NAME_LENGTH];
        unsigned short int age;
        unsigned short int class_number;
        unsigned short int chinese_scores;
        unsigned short int math_scores;
        unsigned short int english_scores;

}Student;

typedef struct stu_class
{
        Student students[MAX_STUDENT_NUMBER];
        unsigned short int class_number;

}Stu_Class;

typedef struct class_system
{
        Stu_Class stu_class[MAX_CLASS_NUMBER];
        //unsigned short int class_sum;
}Class_System;

Class_System class_system;

void Init_Class_System()
{
        memset(&class_system,0,sizeof(Class_System));
        printf("class_system initialization success\n");
}

void Add_A_Student_To_Class_System()
{
        char name[MAX_NAME_LENGTH] ={'\0'};
        unsigned short int age = 0;
        unsigned short int class_number = 0;
        unsigned short int chinese_scores = 0;
        unsigned short int math_scores = 0;
        unsigned short int english_scores = 0;
        unsigned short int number = 0;
        //printf("please input name,age,class_number(1-9),chinese score,math score, english score and the number(1-9)\n");
        printf("input class_number(1-9), stu number(1-9),age, chinese score, math score, english score and name.\n");
        //scanf("%s,%h,%h,%h,%h,%h,%h",name,&age,&class_number,
        //        &chinese_scores,&math_scores,&english_scores,&number);
        scanf("%hd,%hd,%hd,%hd,%hd,%hd,%s", &class_number, &number, &age, &chinese_scores, &math_scores, &english_scores, name);
        printf("class_nu:%d,number:%d, age:%d,chinese:%d,math:%d,english:%d,name:%s.\n",
                              class_number, number, age, chinese_scores, math_scores, english_scores, name);
        //input format: 1,2,3,4,5,6,tom
        strcpy(class_system.stu_class[class_number].students[number].name,name);

        class_system.stu_class[class_number].students[number].age = age;
        class_system.stu_class[class_number].students[number].class_number = class_number;
        class_system.stu_class[class_number].students[number].chinese_scores = chinese_scores;
        class_system.stu_class[class_number].students[number].math_scores = math_scores;
        class_system.stu_class[class_number].students[number].english_scores = english_scores;

        printf("Add student info success!\n");
}

int main()
{
        int i;
        Init_Class_System();
        for(i = 0; i<10;i++)
        {
                Add_A_Student_To_Class_System();
        }

        return 0;
}

进无止进

回复 2# 451006071
谢谢啊，真的是这样，我自己调了很久都没想明白问题在哪儿，还以为是初始化的问题

shang2010

segment fault


一般是没有写过代码的人才会问，