Code 优化: 10* lines to 1* lines?

ulmer

Samba Configuration file: smb.conf

#
# Sample configuration file for the Samba suite for Debian GNU/Linux.
#
#
# This is the main Samba configuration file. You should read the
# smb.conf(5) manual page in order to understand the options listed
# here. Samba has a huge number of configurable options most of which
# are not shown in this example
#
# Any line which starts with a ; (semi-colon) or a # (hash)
# is a comment and is ignored. In this example we will use a #
# for commentary and a ; for parts of the config file that you
# may wish to enable
#
# NOTE: Whenever you modify this file you should run the command
# "testparm" to check that you have not many any basic syntactic
# errors.
#

#======================= Global Settings =======================

[global]

## Browsing/Identification ###

# Change this to the workgroup/NT-domain name your Samba server will part of
   workgroup = HOMENET

# server string is the equivalent of the NT Description field
   server string = %h server (Samba %v)

# Windows Internet Name Serving Support Section:
# WINS Support - Tells the NMBD component of Samba to enable its WINS Server
;   wins support = no

# WINS Server - Tells the NMBD components of Samba to be a WINS Client
# Note: Samba can be either a WINS Server, or a WINS Client, but NOT both
;   wins server = w.x.y.z

# This will prevent nmbd to search for NetBIOS names through DNS.
   dns proxy = no

# What naming service and in what order should we use to resolve host names
# to IP addresses
;   name resolve order = lmhosts host wins bcast


#### Debugging/Accounting ####

# This tells Samba to use a separate log file for each machine
# that connects
   log file = /var/log/samba/log.%m

# Put a capping on the size of the log files (in Kb).
   max log size = 1000

# If you want Samba to only log through syslog then set the following
# parameter to 'yes'.
;   syslog only = no

# We want Samba to log a minimum amount of information to syslog. Everything
# should go to /var/log/samba/log.{smbd,nmbd} instead. If you want to log
# through syslog you should set the following parameter to something higher.
   syslog = 0

# Do something sensible when Samba crashes: mail the admin a backtrace
   panic action = /usr/share/samba/panic-action %d


####### Authentication #######

# "security = user" is always a good idea. This will require a Unix account
# in this server for every user accessing the server. See
# /usr/share/doc/samba-doc/htmldocs/ServerType.html in the samba-doc
# package for details.
   security = user
   username map = /etc/samba/smbusers

# You may wish to use password encryption.  See the section on
# 'encrypt passwords' in the smb.conf(5) manpage before enabling.
   encrypt passwords = true

# If you are using encrypted passwords, Samba will need to know what
# password database type you are using.  
   passdb backend = tdbsam guest

   obey pam restrictions = yes

   guest account = nobody
   invalid users = root

# This boolean parameter controls whether Samba attempts to sync the Unix
# password with the SMB password when the encrypted SMB password in the
# passdb is changed.
;   unix password sync = no

# For Unix password sync to work on a Debian GNU/Linux system, the following
# parameters must be set (thanks to Augustin Luton <aluton@hybrigenics.fr> for
# sending the correct chat script for the passwd program in Debian Potato).
   passwd program = /usr/bin/passwd %u
   passwd chat = *Enter\snew\sUNIX\spassword:* %n\n *Retype\snew\sUNIX\spassword:* %n\n .

# This boolean controls whether PAM will be used for password changes
# when requested by an SMB client instead of the program listed in
# 'passwd program'. The default is 'no'.
;   pam password change = no


########## Printing ##########

# If you want to automatically load your printer list rather
# than setting them up individually then you'll need this
;   load printers = yes

# lpr(ng) printing. You may wish to override the location of the
# printcap file
;   printing = bsd
;   printcap name = /etc/printcap

# CUPS printing.  See also the cupsaddsmb(8) manpage in the
# cupsys-client package.
;   printing = cups
;   printcap name = cups

# When using [print$], root is implicitly a 'printer admin', but you can
# also give this right to other users to add drivers and set printer
# properties
;   printer admin = @ntadmin


######## File sharing ########

# Name mangling options
;   preserve case = yes
;   short preserve case = yes


############ Misc ############

# Using the following line enables you to customise your configuration
# on a per machine basis. The %m gets replaced with the netbios name
# of the machine that is connecting
;   include = /home/samba/etc/smb.conf.%m

# Most people will find that this option gives better performance.
# See smb.conf(5) and /usr/share/doc/samba-doc/htmldocs/speed.html
# for details
# You may want to add the following on a Linux system:
#         SO_RCVBUF=8192 SO_SNDBUF=8192
   socket options = TCP_NODELAY

# The following parameter is useful only if you have the linpopup package
# installed. The samba maintainer and the linpopup maintainer are
# working to ease installation and configuration of linpopup and samba.
;   message command = /bin/sh -c '/usr/bin/linpopup "%f" "%m" %s; rm %s' &

# Domain Master specifies Samba to be the Domain Master Browser. If this
# machine will be configured as a BDC (a secondary logon server), you
# must set this to 'no'; otherwise, the default behavior is recommended.
;   domain master = auto

# Some defaults for winbind (make sure you're not using the ranges
# for something else.)
;   idmap uid = 10000-20000
;   idmap gid = 10000-20000
;   template shell = /bin/bash

#======================= Share Definitions =======================

[homes]
   comment = Home Directories
   browseable = no

# By default, the home directories are exported read-only. Change next
# parameter to 'yes' if you want to be able to write to them.
;   writable = no
   writeable = yes

# File creation mask is set to 0700 for security reasons. If you want to
# create files with group=rw permissions, set next parameter to 0775.
   create mask = 0700

# Directory creation mask is set to 0700 for security reasons. If you want to
# create dirs. with group=rw permissions, set next parameter to 0775.
   directory mask = 0700

# Un-comment the following and create the netlogon directory for Domain Logons
# (you need to configure Samba to act as a domain controller too.)
;[netlogon]
;   comment = Network Logon Service
;   path = /home/samba/netlogon
;   guest ok = yes
;   writable = no
;   share modes = no

;[printers]
;   comment = All Printers
;   browseable = no
;   path = /tmp
;   printable = yes
;   public = no
;   writable = no
;   create mode = 0700

# Windows clients look for this share name as a source of downloadable
# printer drivers
;[print$]
;   comment = Printer Drivers
;   path = /var/lib/samba/printers
;   browseable = yes
;   read only = yes
;   guest ok = no
# Uncomment to allow remote administration of Windows print drivers.
# Replace 'ntadmin' with the name of the group your admin users are
# members of.
;   write list = root, @ntadmin

# A sample share for sharing your CD-ROM with others.
;[cdrom]
;   comment = Samba server's CD-ROM
;   writable = no
;   locking = no
;   path = /cdrom
;   public = yes

# The next two parameters show how to auto-mount a CD-ROM when the
#        cdrom share is accesed. For this to work /etc/fstab must contain
#        an entry like this:
#
#       /dev/scd0   /cdrom  iso9660 defaults,noauto,ro,user   0 0
#
# The CD-ROM gets unmounted automatically after the connection to the
#
# If you don't want to use auto-mounting/unmounting make sure the CD
#        is mounted on /cdrom
#
;   preexec = /bin/mount /cdrom
;   postexec = /bin/umount /cdrom

[public]
   comment = Public Folder
   path = /home/public
   guest ok = yes
   writeable = yes
   create mask = 0777
   directory mask = 0777
   force user = nobody
   force group = nogroup

Perl script to read smb.conf to display shared block(s):
shares.pl

1. 
   
2. #!/usr/bin/perl -w
   
3. 
   
4. use strict;
   
5. 
   
6. sub usage()
   
7.   {
   
8.   print "\n\nProgram shares. Syntax:\n";
   
9.   print "./shares conffile sharename  # prints out params for sharename\n";
   
10.   print "./shares conffile            # prints out params for all shares\n";
    
11.   print "Anything else prints out this message.\n\n";
    
12.   }
    
13. 
    
14. sub newShare(\%$)
    
15.   {
    
16.   %{$_[0]} = ("sharename"=>$_[1]);
    
17.   }
    
18. 
    
19. sub parseSmbDotConf($)
    
20.   {
    
21.   open(CONFIGFILE, "<" . $_[0]) || die "Cannot read file $_[0]\n";
    
22.   my(@configMemoryImage) = <CONFIGFILE>;
    
23.   close(CONFIGFILE);
    
24. 
    
25.   my($state) = "init";
    
26.   my(%allShares);
    
27. 
    
28.   my(%share);
    
29.   my($configLine);
    
30.   foreach $configLine (@configMemoryImage)
    
31.     {
    
32.     if($configLine =~ /^\s*$/) {next;}; #Blow off blank lines
    
33.     chomp($configLine);
    
34.     $configLine =~ s/^\s+//;            #Delete leading blanks
    
35.     $configLine =~ s/\s+$//;            #Delete trailing blanks
    
36.     $configLine =~ s/;.*//;             #Delete comments
    
37.     $configLine =~ s/#.*//;             #Delete comments
    
38.     if($state eq "init")
    
39.       {
    
40.       newShare(%share, "GLOBAL");       #Leading params w/o share are [GLOBAL]
    
41.       $state = "init2";
    
42.       }
    
43. 
    
44.     if($configLine =~ /^\s*\[\s*(.+)\s*\]\s*$/)        #if bracket line
    
45.       {
    
46.       if($state ne "init2")
    
47.         {
    
48.         ### RECORD PRIOR SHARE IN %allShares ###
    
49.         $allShares{$share{"sharename"}} = {%share};
    
50.         }
    
51.       newShare(%share, uc($1));
    
52.       $state = "brackets";
    
53.       }
    
54.     elsif($configLine =~ /^\s*(.+?)\s*=\s*(.+)\s*$/)    #if param line
    
55.       {
    
56.       my($key) = uc($1);
    
57.       my($value) = $2;
    
58.       $key =~ s/\s//g;
    
59.       $share{$key} = $value;
    
60.       $state = "param";
    
61.       }
    
62.     }
    
63.   ### ADD FINAL SHARE TO %allShares ###
    
64.   $allShares{$share{"sharename"}} = {%share};
    
65.   return(%allShares);
    
66.   }
    
67. 
    
68. 
    
69. sub displayOneShare(\%$)
    
70.   {
    
71.   my(%allShares) = %{(shift)};
    
72.   my($shareName) = shift;
    
73.   my(%share) = %{$allShares{$shareName}};
    
74.   my($key,$value);
    
75.   print "\n\n********** [$shareName] **********\n";
    
76.   foreach $key (sort(keys(%share)))
    
77.     {
    
78.     print "$key=" . $share{$key} . "\n";
    
79.     }
    
80.   }
    
81. 
    
82. sub displayAll(\%)
    
83.   {
    
84.   my(%allShares) = %{(shift)};
    
85.   my($key,$value);
    
86.   foreach $key (sort(keys(%allShares)))
    
87.     {
    
88.     displayOneShare(%allShares, $key)
    
89.     }
    
90.   }
    
91. 
    
92. sub main()
    
93.   {
    
94.   my(%shares);
    
95.   if($#ARGV < 0)
    
96.     {
    
97.   usage();
    
98.     }
    
99.   else
    
100.     {
     
101.     %shares = parseSmbDotConf($ARGV[0]);
     
102.     if($#ARGV == 0)
     
103.       {
     
104.       displayAll(%shares);
     
105.       }
     
106.     elsif($#ARGV == 1)
     
107.       {
     
108.       displayOneShare(%shares, uc($ARGV[1]));
     
109.       }
     
110.     else
     
111.       {
     
112.       usage();
     
113.       }
     
114.     }
     
115.   }
     
116. 
     
117. main();
     
118. 
     
119. 
     

复制代码

Above code is copy/past original source.
Who can write more simplified code?
Code Style => simple and short but more readable for normal user,
logical, user -interface friendly?

cobrawgl

写的可真乱。。。

这样的代码真是坏 perl 的名声啊

{:3_183:}

Ray001

缩进的格式有点乱。
推荐perltidy

ttcn_cu

1. #!perl
   
2. use strict;
   
3. use warnings;
   
4. {
   
5.         my $vl_section='';
   
6.         my $pl_userinput=qr/.*/;
   
7.         defined $ARGV[1] and $pl_userinput=$ARGV[1];
   
8.         open IN,$ARGV[0];
   
9.         while (<IN>){
   
10.                 /^\[(\w+)\]$/ and do {
    
11.                         $vl_section=$1;
    
12.                         $vl_section=~/^$pl_userinput$/ and print "******* [$vl_section] *******\n";
    
13.                         next;
    
14.                 };
    
15.                 $vl_section=~/^$pl_userinput$/ && /^\s*([\w\s]+)\s*=\s*(.*)$/ and do {
    
16.                         print uc($1)."=$2\n";
    
17.                         next;
    
18.                 };
    
19.         }
    
20.         close IN;
    
21. }

复制代码

好难减到10* 良心上减不下去了

DQP

1. 
   
2. my $config_file = shift or die "missing conffile\n";
   
3. open my $conf_fh, "<", $config_file;
   
4. my $str = join "", grep { !m/^$/ } map { s/^\s*//; s/[#;].*$//; $_ } <$conf_fh>;
   
5. my @sections = $str =~ m/\[(?<section>\w+)\]/mxg;
   
6. @sections = shift if(@ARGV);
   
7. for(@sections){
   
8.     printf "********** [%s] **********\n", $_;
   
9.     print $str =~ m/ \[(?:$_)\]\s*$ \s ((?:[\w\s]+\s*=\s*.+\s*$ \s)*) /mxg;
   
10. }
    
11. 
    

复制代码

DQP

1. 
   
2. use Config::Std;
   
3. my $config_file = shift || die "missing conffile\n";
   
4. read_config $config_file => my %config;
   
5. foreach my $section (shift || keys %config){
   
6.     printf "\n\n********** [%s] **********\n", $section;
   
7.     printf "%s=%s\n", $_, ${$config{$section}}{$_} for keys %{$config{$section}};
   
8. }
   
9. 
   

复制代码

redicaps

这个code是传说中的gnu风格么？

DQP

回复 7# redicaps


    好像还不是

ttcn_cu

果然是不短不perl啊

ttcn_cu

1. my ($vl_section,$pl_userinput) = ( '' , defined $ARGV[1] ? join "|",@ARGV[1..$#ARGV] : qr/.*/);
   
2. open IN,$ARGV[0] or die $!;
   
3. while (<IN>){
   
4.         /^\[(\w+)\]$/ && ($vl_section=$1) =~/^$pl_userinput$/ and print "******* [$vl_section] *******\n";
   
5.         $vl_section=~/^$pl_userinput$/ && /^\s*([\w\s]+)\s*=\s*(.*)$/ and print $_;
   
6. }

复制代码

再压缩一下