免费注册 查看新帖 |

Chinaunix

  平台 论坛 博客 文库
最近访问板块 发新帖
查看: 734 | 回复: 0
打印 上一主题 下一主题

Coding Style Guidelines from webkit [复制链接]

论坛徽章:
0
跳转到指定楼层
1 [收藏(0)] [报告]
发表于 2009-03-06 11:52 |只看该作者 |倒序浏览
WebKit Coding Style Guidelines
Indentation
  • Use spaces, not tabs. Tabs should only appear in files that require them for semantic meaning, like Makefiles.
  • The indent size is 4 spaces.
    Right:
    int main()
    {
        return 0;
    }
    Wrong:
    int main()
    {
            return 0;
    }
  • In a header, code inside a namespace should be indented.
    Right:
    // Document.h
    namespace WebCore {
        class Document {
            Document();
            ...
        };
    } // namespace WebCore
    Wrong:
    // Document.h
    namespace WebCore {
    class Document {
        Document();
        ...
    };
    } // namespace WebCore
  • In an implementation file (files with the extension .cpp, .c or .mm), code inside a namespace should not be indented.
    Right:
    // Document.cpp
    namespace WebCore {
    Document::Document()
    {
        ...
    }
    } // namespace WebCore
    Wrong:
    // Document.cpp
    namespace WebCore {
        Document::Document()
        {
            ...
        }
    } // namespace WebCore
  • A case label should line up with its switch statement.  The case statement is indented.
    Right:
    switch (condition) {
    case fooCondition:
    case barCondition:
        i++;
        break;
    default:
        i--;
    }
    Wrong:
    switch (condition) {
        case fooCondition:
        case barCondition:
            i++;
            break;
        default:
            i--;
    }
  • Boolean expressions at the same nesting level that span multiple lines should
    have their operators on the left side of the line instead of the right side.
    Right:
    return attr->name() == srcAttr
        || attr->name() == lowsrcAttr
        || (attr->name() == usemapAttr && attr->value().domString()[0] != '#');
    Wrong:
    return attr->name() == srcAttr ||
        attr->name() == lowsrcAttr ||
        (attr->name() == usemapAttr && attr->value().domString()[0] != '#');
    Spacing
  • Do not place spaces around unary operators.
    Right:
    i++;
    Wrong:
    i ++;
  • Do place spaces around binary and ternary operators.
    Right:
    y = m * x + b;
    f(a, b);
    c = a | b;
    return condition ? 1 : 0;
    Wrong:
    y=m*x+b;
    f(a,b);
    c = a|b;
    return condition ? 1:0;
  • Place spaces between control statements and their parentheses.
    Right:
    if (condition)
        doIt();
    Wrong:
    if(condition)
        doIt();
  • Do not place spaces between a function and its parentheses, or between a parenthesis and its content.
    Right:
    f(a, b);
    Wrong:
    f (a, b);
    f( a, b );
    Line breaking
  • Each statement should get its own line.
    Right:
    x++;
    y++;
    if (condition)
        doIt();
    Wrong:
    x++; y++;
    if (condition) doIt();
  • An else statement should go on the same line as a preceding close brace.
    Right:
    if (condition) {
        ...
    } else {
        ...
    }
    Wrong:
    if (condition) {
        ...
    }
    else {
        ...
    }
  • An else if statement should be written as an if statement when the prior if concludes with a return statement.
    Right:
    if (condition) {
        ...
        return someValue;
    }
    if (condition) {
        ...
    }
    Wrong:
    if (condition) {
        ...
        return someValue;
    } else if (condition) {
        ...
    }
    Braces
  • Function definitions: place each brace on its own line.
    Right:
    int main()
    {
        ...
    }
    Wrong:
    int main() {
        ...
    }
  • Other braces: place the open brace on the line preceding the code block; place the close brace on its own line.
    Right:
    class MyClass {
        ...
    };
    namespace WebCore {
        ...
    }
    for (int i = 0; i
    Wrong:
    class MyClass
    {
        ...
    };
  • One-line control clauses should not use braces
    Right:
    if (condition)
        doIt();
    Wrong:
    if (condition) {
        doIt();
    }
  • Control clauses without a body should use empty braces:
    Right:
    for ( ; current; current = current->next) { }
    Wrong:
    for ( ; current; current = current->next);
    Null, false and 0
  • In C++, the null pointer value should be written as 0. In C, it should be written as NULL. In Objective-C and Objective-C++, follow the guideline for C or C++, respectively, but use nil to represent a null Objective-C object.
  • C++ and C bool values should be written as true and false. Objective-C BOOL values should be written as YES and NO.
  • Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.
    Right:
    if (condition)
        doIt();
       
    if (!ptr)
        return;
    if (!count)
        return;
    Wrong:
    if (condition == true)
        doIt();
       
    if (ptr == NULL)
        return;
       
    if (count == 0)
        return;
  • In Objective-C, instance variables are initialized to zero
    automatically. Don't add explicit initializations to nil or NO in an
    init method.
    Names
  • Use CamelCase. Capitalize the first letter, including all letters
    in an acronym, in a class, struct, protocol, or namespace name.
    Lower-case the first letter, including all letters in an acronym, in a
    variable or function name.
    Right:
    struct Data;
    size_t bufferSize;
    class HTMLDocument;
    String mimeType();
    Wrong:
    struct data;
    size_t buffer_size;
    class HtmlDocument;
    String MIMEType();
  • Use full words, except in the rare case where an abbreviation would be more canonical and easier to understand.
    Right:
    size_t characterSize;
    size_t length;
    short tabIndex; // more canonical
    Wrong:
    size_t charSize;
    size_t len;
    short tabulationIndex; // bizarre
  • Prefix C++ data members with "m_".
    Right:
    class String {
        ...
        short m_length;
    };
    Wrong:
    class String {
        ...
        short length;
    };
  • Prefix Objective-C instance variables with "_".
    Right:
    @class String
        ...
        short _length;
    @end
    Wrong:
    @class String
        ...
        short length;
    @end
  • Precede boolean values with words like "is" and "did".
    Right:
    bool isValid;
    bool didSendData;
    Wrong:
    bool valid;
    bool sentData;
  • Precede setters with the word "set". Use bare words for getters.
    Setter and getter names should match the names of the variables being
    set/gotten.
    Right:
    void setCount(size_t); // sets m_count
    size_t count(); // returns m_count
    Wrong:
    void setCount(size_t); // sets m_theCount
    size_t getCount();
  • Use descriptive verbs in function names.
    Right:
    bool convertToASCII(short*, size_t);
    Wrong:
    bool toASCII(short*, size_t);
  • Leave meaningless variable names out of function declarations.
    Right:
    void setCount(size_t);
    Wrong:
    void setCount(size_t count);
  • Objective-C method names should follow the Cocoa naming guidelines —
    they should read like a phrase and each piece of the selector should
    start with a lowercase letter and use intercaps.
  • Enum members should user InterCaps with an initial capital letter.
  • Prefer const to #define. Prefer inline functions to macros.
  • #defined constants should use all uppercase names with words separated by underscores.
  • Macros that expand to function calls or other non-constant computation: these
    should be named like functions, and should have parentheses at the end, even if
    they take no arguments (with the exception of some special macros like ASSERT).
    Note that usually it is preferable to use an inline function in such cases instead of a macro.
    Right:
    #define WBStopButtonTitle() \
            NSLocalizedString(@"Stop", @"Stop button title")
    Wrong:
    #define WB_STOP_BUTTON_TITLE \
            NSLocalizedString(@"Stop", @"Stop button title")
    #define WBStopButtontitle \
            NSLocalizedString(@"Stop", @"Stop button title")
  • #define, #ifdef "header guards" should be named exactly the same as the file (including case), replacing the '.' with a '_'.
    Right:
    // HTMLDocument.h
    #ifndef HTMLDocument_h
    #define HTMLDocument_h
    Wrong:
    // HTMLDocument.h
    #ifndef _HTML_DOCUMENT_H_
    #define _HTML_DOCUMENT_H_
    Other Punctuation
  • Constructors for C++ classes should initialize all of their members using C++
    initializer syntax.  Each member (and superclass) should be indented on a separate
    line, with the colon or comma preceding the member on that line.
    Right:
    MyClass::MyClass(Document* doc)
        : MySuperClass()
        , m_myMember(0)
        , m_doc(doc)
    {
    }
    MyOtherClass::MyOtherClass()
        : MySuperClass()
    {
    }
    Wrong:
    MyClass::MyClass(Document* doc) : MySuperClass()
    {
        m_myMember = 0;
        m_doc = doc;
    }
    MyOtherClass::MyOtherClass() : MySuperClass() {}
  • Pointer types in non-C++ code — Pointer types should be written with a space between the
    type and the * (so the * is adjacent to the following identifier if any).
  • Pointer and reference types in C++ code — Both pointer types and reference types
    should be written with no space between the type name and the * or &.
    Right:
    Image* SVGStyledElement::doSomething(PaintInfo& paintInfo)
    {
        SVGStyledElement* element = static_cast(node());
        const KCDashArray& dashes = dashArray();
    Wrong:
    Image *SVGStyledElement::doSomething(PaintInfo &paintInfo)
    {
        SVGStyledElement *element = static_cast(node());
        const KCDashArray &dashes = dashArray();
    #include Statements
  • All implementation files must #include "config.h" first. Header
    files should never include "config.h".
    Right:
    // RenderLayer.h
    #include "Node.h"
    #include "RenderObject.h"
    #include "RenderView.h"
    Wrong:
    // RenderLayer.h
    #include "config.h"
    #include "RenderObject.h"
    #include "RenderView.h"
    #include "Node.h"
  • All implementation files must #include the primary header second,
    just after "config.h". So for example, Node.cpp should include Node.h first,
    before other files. This guarantees that each header's completeness is tested.
    This also assures that each header can be compiled without requiring any other
    header files be included first.
  • Other #include statements should be in sorted order (case sensitive, as
    done by the command-line sort tool or the Xcode sort selection command).
    Don't bother to organize them in a logical order.
    Right:
    // HTMLDivElement.cpp
    #include "config.h"
    #include "HTMLDivElement.h"
    #include "Attribute.h"
    #include "HTMLElement.h"
    #include "QualifiedName.h"
    Wrong:
    // HTMLDivElement.cpp
    #include "HTMLElement.h"
    #include "HTMLDivElement.h"
    #include "QualifiedName.h"
    #include "Attribute.h"
                   
                   
                   

    本文来自ChinaUnix博客,如果查看原文请点:http://blog.chinaunix.net/u/28158/showart_1853498.html
  • 您需要登录后才可以回帖 登录 | 注册

    本版积分规则 发表回复

      

    北京盛拓优讯信息技术有限公司. 版权所有 京ICP备16024965号-6 北京市公安局海淀分局网监中心备案编号:11010802020122 niuxiaotong@pcpop.com 17352615567
    未成年举报专区
    中国互联网协会会员  联系我们:huangweiwei@itpub.net
    感谢所有关心和支持过ChinaUnix的朋友们 转载本站内容请注明原作者名及出处

    清除 Cookies - ChinaUnix - Archiver - WAP - TOP