发现libevent有个bug

liexusong

其实不算是bug, 只是觉得有点浪费内存而已, 代码如下:

1. int
   
2. event_base_priority_init(struct event_base *base, int npriorities)
   
3. {
   
4.         int i;
   
5. 
   
6.         if (base->event_count_active)
   
7.                 return (-1);
   
8. 
   
9.         if (base->nactivequeues && npriorities != base->nactivequeues) {
   
10.                 for (i = 0; i < base->nactivequeues; ++i) {
    
11.                         free(base->activequeues[i]);
    
12.                 }
    
13.                 free(base->activequeues);
    
14.         }
    
15. 
    
16.         /* Allocate our priority queues */
    
17.         base->nactivequeues = npriorities;
    
18.         base->activequeues = (struct event_list **)calloc(base->nactivequeues,
    
19.             npriorities * sizeof(struct event_list *));
    
20.         if (base->activequeues == NULL)
    
21.                 event_err(1, "%s: calloc", __func__);
    
22. 
    
23.         for (i = 0; i < base->nactivequeues; ++i) {
    
24.                 base->activequeues[i] = malloc(sizeof(struct event_list));
    
25.                 if (base->activequeues[i] == NULL)
    
26.                         event_err(1, "%s: malloc", __func__);
    
27.                 TAILQ_INIT(base->activequeues[i]);
    
28.         }
    
29. 
    
30.         return (0);
    
31. }

复制代码

在第18行:
base->activequeues = (struct event_list **)calloc(base->nactivequeues,
            npriorities * sizeof(struct event_list *));

我觉得应该改为:
base->activequeues = (struct event_list **)calloc(base->nactivequeues,
            sizeof(struct event_list *));

leejqy

标题党

hellioncu

那23、24行的循环对 base->activequeues[i] 赋值不是越界了么？