找不到问题出在哪里, 请帮忙

sunzhiguolu

我的代码如下:

1. #!/usr/bin/perl
   
2. use strict;
   
3. use warnings;
   
4. 
   
5. sub get_min_item{
   
6.     my ($luck, $hash, $min, %hData) = (@_, 0);
   
7.     my $fmt = "'px' = %d, 'dt' = '%d'\n";
   
8.     foreach my $k (keys %$hash){
   
9.         my ($num, $item) = map {$_, $hash->{$k}{$_}} sort {$a <=> $b} keys %{$hash->{$k}};
   
10.         $hData{$k} = [$num, $item->{'px'}, $item->{'dt'}];
    
11.     }
    
12.     my ($px, $dt);
    
13.     foreach (map { $min = $_->[-1] if (!$min); $min eq $_->[-1] ? $_->[0] : () } sort {$a->[1] <=> $b->[1]} map {[$_, @{$hData{$_}}]} keys %hData){
    
14.         return sprintf($fmt,@{$hData{$_}}[1,-1]) if ($luck eq $_);
    
15.         if ($_ ne $luck and !$px){
    
16.             ($px, $dt) = @{$hData{$_}}[1, -1];
    
17.             #print "IN!<$px|$dt>\n";
    
18.         }
    
19.     }
    
20.     print "OUT!<$px|$dt>\n";    # 执行不到这里, 为啥呀!!!
    
21.     #return sprintf($fmt,$px,$dt);
    
22. }
    
23. 
    
24. my $hash1 = +{
    
25. 'CSH' => { '3' => {'px' => 20, 'dt' => '20161221'}, '4' => {'px' => 10, 'dt' => '20161221'} },
    
26. 'OTH' => { '1' => {'px' => 30, 'dt' => '20161221'}, '2' => {'px' => 40, 'dt' => '20171221'} },
    
27. 'ABC' => { '2' => {'px' => 10, 'dt' => '20191221'}, '3' => {'px' => 25, 'dt' => '20201221'} },
    
28. };
    
29. 
    
30. my $hash2 = +{
    
31. 'CSH' => {'3' => {'px' => 10, 'dt' => '20161221'}, '4' => {'px' => 10, 'dt' => '20161221'}},
    
32. 'OTH' => {'1' => {'px' => 30, 'dt' => '20161221'}, '2' => {'px' => 40, 'dt' => '20171221'}},
    
33. 'ABC' => {'2' => {'px' => 10, 'dt' => '20191221'}, '3' => {'px' => 25, 'dt' => '20201221'}},
    
34. };
    
35. 
    
36. get_min_item ('CSH', $hash2);
    

复制代码

RE_HASH

perl -d 调试一下

不懂你的逻辑。为啥在循环里return？

jason680

自讨苦吃??

foreach (map { $min = $_->[-1] if (!$min); $min eq $_->[-1] ? $_->[0] : () } sort {$a->[1] <=> $b->[1]} map {[$_, @{$hData{$_}}]} keys %hData)

sunzhiguolu

回复 2# RE_HASH
在循环中用 return 比较快捷, 大神帮我看下 哪里出问题了!

   

sunzhiguolu

jason680 发表于 2016-08-11 23:53
自讨苦吃??

foreach (map { $min = $_->[-1] if (!$min); $min eq $_->[-1] ? $_->[0] : () } sort {$a- ...

sunzhiguolu

1. #!/usr/bin/perl
   
2. use strict;
   
3. use warnings;
   
4. 
   
5. sub get_min_item{
   
6.     my ($luck, $hash, $min, %hData) = (@_, 0);
   
7.     my $fmt = "'px' = %d, 'dt' = '%d'\n";
   
8.     foreach my $k (keys %$hash){
   
9.         my ($num, $item) = map {$_, $hash->{$k}{$_}} sort {$a <=> $b} keys %{$hash->{$k}};
   
10.         $hData{$k} = [$num, $item->{'px'}, $item->{'dt'}];
    
11.     }
    
12.     my ($px, $dt);
    
13.     foreach (map { $min = $_->[-1] if (!$min); $min eq $_->[-1] ? $_->[0] : () } sort {$a->[1] <=> $b->[1] and $a->[-1] <=> $b->[-1]} map {[$_, @{$hData{$_}}]} keys %hData){
    
14.         ($px, $dt) = @{$hData{$_}}[1, -1] if ($luck eq $_);
    
15.         ($px, $dt) = @{$hData{$_}}[1, -1] if ($_ ne $luck and !$px);
    
16.     }
    
17.     return sprintf($fmt,$px,$dt);
    
18. }
    
19. 
    
20. my $hash1 = +{
    
21. 'CSH' => { '3' => {'px' => 20, 'dt' => '20161221'}, '4' => {'px' => 10, 'dt' => '20161221'} },
    
22. 'OTH' => { '1' => {'px' => 30, 'dt' => '20161221'}, '2' => {'px' => 40, 'dt' => '20171221'} },
    
23. 'ABC' => { '2' => {'px' => 10, 'dt' => '20191221'}, '3' => {'px' => 25, 'dt' => '20201221'} },
    
24. };
    
25. 
    
26. my $hash2 = +{
    
27. 'OTH' => {'1' => {'px' => 30, 'dt' => '20161221'}, '2' => {'px' => 40, 'dt' => '20171221'}},
    
28. 'ABC' => {'2' => {'px' => 10, 'dt' => '20191221'}, '3' => {'px' => 25, 'dt' => '20201221'}},
    
29. };
    
30. 
    
31. print get_min_item ('CSH', $_) for ($hash1, $hash2);
    

复制代码

将 foreach 内的 return 去掉果然正常了, 为啥呀, 哪位大神给个解释, 谢谢...

RE_HASH

函数子程序最好是单出口，漏斗和筛子的区别。

jason680

回复 5# sunzhiguolu

http://bbs.chinaunix.net/thread-677935-1-1.html

http://wenku.baidu.com/view/f3ab1e7bf12d2af90242e6ce.html?re=view

...   
编写的代码难以调试，却还要试图从中找出错误。
...

zhlong8

谁能把这函数写成一行？

sunzhiguolu

回复 8# jason680
大神 我那个 foreach 的确长了点, 我是为了进行排序, 筛选 如果是在 foreach 外部进行操作 好像不太好实现吧.